Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TOOL-3021] Insight Playground: Enforce chain query param to be required + support anyOf schema #5925

Merged
merged 1 commit into from
Jan 11, 2025
Merged

[TOOL-3021] Insight Playground: Enforce chain query param to be required + support anyOf schema #5925

merged 1 commit into from
Jan 11, 2025

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Jan 10, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on modifying the handling of parameters in the blueprint-playground.client.tsx file, specifically making the chain parameter required and refining the schema conversion logic for parameters.

Detailed summary

  • Changed the chain parameter to be required if it exists.
  • Updated the openAPIV3ParamToZodFormSchema function to accept schema and isRequired as arguments.
  • Adjusted logic to check for required status using isRequired instead of param.required.
  • Enhanced handling of anyOf schemas.
  • Updated the creation of parameter schemas to reflect required status in various cases.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel Vercel
Copy link

vercel bot commented Jan 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2025 2:27am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 11, 2025 2:27am
thirdweb_playground ⬜️ Skipped (Inspect) Jan 11, 2025 2:27am
wallet-ui ⬜️ Skipped (Inspect) Jan 11, 2025 2:27am

@linear Linear
Copy link

linear bot commented Jan 10, 2025

TOOL-3021 Insight playground: Enforce Chain param to be required, support anyOf schema

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 10, 2025 11:51 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 10, 2025 11:51 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 10, 2025 11:51 Inactive
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6953d06

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 10, 2025
@MananTank MananTank marked this pull request as ready for review January 10, 2025 11:51
@MananTank MananTank requested review from a team as code owners January 10, 2025 11:51
@MananTank Graphite App
Copy link
Member Author

MananTank commented Jan 10, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.83%. Comparing base (4b5661b) to head (6953d06).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5925   +/-   ##
=======================================
  Coverage   54.83%   54.83%           
=======================================
  Files        1141     1141           
  Lines       60903    60903           
  Branches     5128     5128           
=======================================
  Hits        33396    33396           
  Misses      26781    26781           
  Partials      726      726
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 4b5661b
packages 52.47% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.65 KB (0%) 913 ms (0%) 2.9 s (-11.64% 🔽) 3.8 s
thirdweb (cjs) 115.43 KB (0%) 2.4 s (0%) 6.9 s (+48.93% 🔺) 9.2 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 146 ms (-46.56% 🔽) 257 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 43 ms (+14.29% 🔺) 53 ms
thirdweb/react (minimal + tree-shaking) 19.21 KB (0%) 385 ms (0%) 492 ms (-19.03% 🔽) 877 ms

@graphite-app Graphite App
Copy link

graphite-app bot commented Jan 11, 2025 •
edited
Loading

Merge activity

@jnsdls jnsdls force-pushed the 01-10-_tool-3021_insight_playground_enforce_chain_query_param_to_be_required_support_anyof_schema branch from ff591b9 to 6953d06 Compare January 11, 2025 02:19
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 11, 2025 02:19 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 11, 2025 02:19 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 11, 2025 02:19 Inactive
@graphite-app graphite-app bot merged commit 6953d06 into main Jan 11, 2025
32 checks passed
@graphite-app graphite-app bot deleted the 01-10-_tool-3021_insight_playground_enforce_chain_query_param_to_be_required_support_anyof_schema branch January 11, 2025 02:28
@vercel vercel bot temporarily deployed to Production – thirdweb_playground January 11, 2025 02:28 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 January 11, 2025 02:28 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui January 11, 2025 02:28 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnsdls jnsdls jnsdls approved these changes

@joaquim-verges joaquim-verges joaquim-verges approved these changes

Assignees

@MananTank MananTank

Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MananTank @joaquim-verges @jnsdls